Fix FloatingBox merged refs being overwritten by ref prop in React 19
#3974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for storybook-navy-digital-mod-uk ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thyhjwb6
added
Type: Bug
thyhjwb6
force-pushed
the
issue-3969/fix-floating-box-ref-rest
branch
from
e0b7722 to
1362d86
Compare
thyhjwb6
changed the title
FloatingBox merged refs being overwritten by ref prop in React 19
m7kvqbe1
approved these changes
Dec 20, 2024
| data-testid="floating-box" | ||
| {...attributes.popper} | ||
| {...rest} | ||
| /* |
There was a problem hiding this comment.
Sorry, this is really nitpicky but could we change the comment style to:
//
//
//
When using React 19, ref is a prop and was being overwritten with {...rest}.
Setup functions can be safely abstracted and reused across tests.
thyhjwb6
force-pushed
the
issue-3969/fix-floating-box-ref-rest
branch
from
1362d86 to
00fe246
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #3969
Overview
Fixes an issue when using React 19 which adds the
refas a prop. This was overwriting the merged refs because it isnull.Reason
The floating box for the
DatePickeris positioned incorrectly.Work carried out
refissueTest instructions
Follow the reproduction steps in the original issue.
Developer notes
A follow up to this (hopefully tomorrow) will be to replace React Popper with Floating UI.